Skip to content

Conversation

@alex-reiff
Copy link
Contributor

Description

Move any tests using KMS to au-syd.

issue: https://github.ibm.com/GoldenEye/issues/issues/12725

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@alex-reiff alex-reiff requested a review from shemau as a code owner March 19, 2025 02:40
@alex-reiff
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the default value of region in the examples too please incase people manually provision the example locally.

@alex-reiff
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 58469c4 into main Mar 19, 2025
2 checks passed
@ocofaigh ocofaigh deleted the kms-region branch March 19, 2025 15:43
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.25.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants